https://github.com/jmorse commented:
Just to check my understanding, things like CHECK-MAIN-CRT-SAME are going to shift the match-position that FileCheck is looking at forwards, so that we have to match in the correct order, yes? I get the feeling that given how much of the construct-a-job logic filters for `!Relocatable` it might be worth having that as an early exit. On the other hand, the logic here is already a complicated matrix of expectations, no need to make it more complicated in the name of lines-of-code. For the CHECK-NO... flavour of checklines, would they be better as `--check-implicit-not` arguments to FileCheck, or is it alright to rely on them being in a rigid order? (No strong opinion). https://github.com/llvm/llvm-project/pull/115497 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
