https://github.com/jmorse approved this pull request.
> I don't find its current state especially offensive, but I could have a go at > moving the new stuff to some helper functions, perhaps? If it's manageable then it's manageable, > I have a very slight preference to revert this particular commit as I feel > there's slightly more chance for error now, though I did validate with some > experiments. Let me know what you think. Yeah, while there might be slightly more coverage it comes at the cost of considerable uglyness, so backing that out sounds is preferable to me too. Does the flipped order of library-option-names in 100c3c271 have an actual effect on behaviour? Just curious. LGTM https://github.com/llvm/llvm-project/pull/115497 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
