https://github.com/wangpc-pp commented:
Thanks! I just had a detailed look. Given that you have explained almost all the code detailedly, I think this PR looks great to me! Just some overall comments: 1. I personally like your proposal of adding new constraints, but we still need the agreement between community members. 2. I saw all the comments above and I know reason why we choose to add new MVT types. My question is, maybe we can make it less target-specific? I don't think this is a RISC-V only problem. 3. We should be able to use `Pr` for Zacas now? So maybe we should add some tests for it. https://github.com/llvm/llvm-project/pull/112983 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
