llvm-beanz wrote:

I think we could all benefit from some documentation describing how the SYCL 
compiler flow is intended to work, what tools are added/modified, and what the 
expected outputs are at each compiler phase. Without some idea of the 
architecture of what is being built changes like this and #110771 don't make 
sense and are really difficult to review.

This isn't like introducing a new backend or something where we have a defined 
and understood architecture to evaluate against. We're getting patches that 
only represent small parts of the whole without any context to understand how 
it will all come together in the end.

What worries me is that from the parts I see, it doesn't align with any of the 
community design principles.

https://github.com/llvm/llvm-project/pull/112245
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to