timshen added inline comments.

================
Comment at: llvm/include/llvm/ADT/APFloat.h:1039
+  /// \brief Operator+ overload which provides the default
+  /// \c nmNearestTiesToEven rounding mode and *no* error checking.
   APFloat operator+(const APFloat &RHS) const {
----------------
echristo wrote:
> What's with the no error checking. Also, unless my font kerning is terrible 
> you have nmNearestTiesToEven versus rmNearestTiesToEven.
That original IEEEFloat does so. I think it's reasonable, since the operators 
are mostly for convenience, while a serious user should use 
add/subtract/multiply/divide.

Fixed the typo.


https://reviews.llvm.org/D27872



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to