tbaederr wrote: Yeah the behavior is not the same. The original code only parsed `ident[,]` in the loop, since the `continue` ended the loop anyway.
The comment above the function reads: ``` /// [ObjC] protocol-qualifiers: //// '<' identifier-list '>' ``` So the assumption is that this should parse multiple identifiers, and not just one. I think the new code does that. I'm only worried about the missing return at the end of the function - maybe there should be a `llvm_unreachable` here to silence compilers, even if that control flow is not possible. https://github.com/llvm/llvm-project/pull/109298 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
