smeenai added inline comments.
================
Comment at: CMakeLists.txt:394
# non-debug DLLs
remove_flags("/D_DEBUG" "/MTd" "/MDd" "/MT" "/Md" "/RTC1")
----------------
EricWF wrote:
> smeenai wrote:
> > EricWF wrote:
> > > smeenai wrote:
> > > > We should be able to remove this now, right?
> > > I would still rather strip it and re-add it. Just incase it gets added by
> > > LLVM or another parent project.
> > Not completely sure I understand. Isn't this gonna be coming from cmake
> > itself?
> Yes, that was the original reason. Although it's possible an evil user could
> also add it.
>
> I would rather handle it manually instead of depending on implicit default
> flags.
Ah, fair enough.
I think the `/RTC1` doesn't need to be stripped out anymore, at least in debug
mode (the extra checking might be useful).
================
Comment at: test/support/set_windows_crt_report_mode.h:1
+#ifndef SUPPORT_SET_WINDOWS_CRT_REPORT_MODE_H
+#define SUPPORT_SET_WINDOWS_CRT_REPORT_MODE_H
----------------
Does this need the LLVM license header?
https://reviews.llvm.org/D28725
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
