EricWF added inline comments.
================
Comment at: CMakeLists.txt:394
# non-debug DLLs
remove_flags("/D_DEBUG" "/MTd" "/MDd" "/MT" "/Md" "/RTC1")
----------------
smeenai wrote:
> EricWF wrote:
> > smeenai wrote:
> > > We should be able to remove this now, right?
> > I would still rather strip it and re-add it. Just incase it gets added by
> > LLVM or another parent project.
> Not completely sure I understand. Isn't this gonna be coming from cmake
> itself?
Yes, that was the original reason. Although it's possible an evil user could
also add it.
I would rather handle it manually instead of depending on implicit default
flags.
https://reviews.llvm.org/D28725
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
