khazem added a comment.

Sorry for the late comment, but one of the tests that this introduces is 
breaking on my end:

  
/usr/local/google/home/khazem/doc/llvm/tools/clang/test/ASTMerge/class-template-partial-spec.cpp:9:11:
 error: expected string not found in input
  // CHECK: 
/media/build/smrc-llvm/master/llvm/tools/clang/test/ASTMerge/Inputs/class-template-partial-spec2.cpp:21:32:
 error: external variable 'X1' declared with incompatible types in different 
translation units ('TwoOptionTemplate<int, double>' vs. 'TwoOptionTemplate<int, 
float>')
            ^
  <stdin>:1:1: note: scanning from here
  
/usr/local/google/home/khazem/doc/llvm/tools/clang/test/ASTMerge/Inputs/class-template-partial-spec1.cpp:20:30:
 error: external variable 'X0' defined in multiple translation units
  ^
  <stdin>:7:15: note: possible intended match here
  
/usr/local/google/home/khazem/doc/llvm/tools/clang/test/ASTMerge/Inputs/class-template-partial-spec2.cpp:21:32:
 error: external variable 'X1' declared with incompatible types in different 
translation units ('TwoOptionTemplate<int, double>' vs. 'TwoOptionTemplate<int, 
float>')
                ^

Is this expected?


https://reviews.llvm.org/D26753



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to