spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Yeah, that test looks great! Thanks!
================
Comment at: lib/AST/ASTImporter.cpp:496
+ return false;
+ if (DN1->isIdentifier())
+ return IsStructurallyEquivalent(DN1->getIdentifier(),
----------------
spyffe wrote:
> We should probably also check whether `DN1->isIdentifier() ==
> DN2->isIdentifier()`.
Looking at my comment with fresh post Thanksgiving eyes, that would be totally
wrong. The `IsStructurallyEquivalent` is fine.
================
Comment at:
test/ASTMerge/class-template-partial-spec/Inputs/class-template-partial-spec2.cpp:67
+template<typename T, typename X>
+struct Child1: public Two::Three::Parent<unsigned> {
+ char member;
----------------
ooh, nice!
https://reviews.llvm.org/D26753
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
