vangyzen added inline comments.

================
Comment at: 
test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp:50
+        }
         std::locale l(LOCALE_en_US_UTF_8);
         {
----------------
EricWF wrote:
> I think we should reset the global locale so it's different than the one we 
> pass to `std::locale l(...)`. That way we're testing that we don't accidental 
> use the global locale.
Good idea.


https://reviews.llvm.org/D26979



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to