sebpop added a comment. Other than removing that comment the patch looks good. Thanks!
================ Comment at: libcxx/src/string.cpp:10 +// For keeping the definition of ~basic_string in this translation unit. +#define _LIBCPP_BUILDING_STRING ---------------- Let's not add this comment here, as this define may be used in the future for other purposes. Also a simple grep would give you the places where this is used. https://reviews.llvm.org/D25624 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
