sebpop added inline comments.
================ Comment at: libcxx/include/string:1841 template <class _CharT, class _Traits, class _Allocator> +inline _LIBCPP_HEADER_INLINE_VISIBILITY basic_string<_CharT, _Traits, _Allocator>::~basic_string() ---------------- and let's also use the define just here: #ifndef _LIBCPP_BUILDING_STRING inline _LIBCPP_INLINE_VISIBILITY #endif ================ Comment at: libcxx/src/string.cpp:10 +#define _LIBCPP_HEADER_INLINE_VISIBILITY + ---------------- To be consistent with memory.cpp: #define _LIBCPP_BUILDING_MEMORY let's rename the define as: #define _LIBCPP_BUILDING_STRING https://reviews.llvm.org/D25624 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
