jhuber6 wrote: > That said, I definitely don't want this to be a barrier to getting this patch > in, so if you still feel like we should go with the clang-format > recommendation, I'll change it and also update the EmitAssembly and > EmitBackendOutput signatures which were flagged by clang-format for the same > reasons.
You should generally just go with what `clang-format` says unless there's a compelling reason not to. There's a reason the CI complains if `git clang-format HEAD~1` doesn't come back clean. https://github.com/llvm/llvm-project/pull/69371 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
