jhuber6 wrote:

> I am getting this from the formatter:
> 
> ```
> -  void RunOptimizationPipeline(BackendAction Action,
> -                          std::unique_ptr<raw_pwrite_stream> &OS,
> -                          std::unique_ptr<llvm::ToolOutputFile> &ThinLinkOS,
> -                          BackendConsumer *BC);
> +  void RunOptimizationPipeline(
> +      BackendAction Action, std::unique_ptr<raw_pwrite_stream> &OS,
> +      std::unique_ptr<llvm::ToolOutputFile> &ThinLinkOS, BackendConsumer 
> *BC);
> ```
> 
> But in this case I am just following the existing style. I did notice a 
> couple of other improvements from the formatter though, and I've added those 
> changes.

Just do what the formatter says, not every file is 100% clang-formatted so 
there's bits of old code that haven't been properly cleaned yet. This was the 
same line that I thought looked wrong so it should probably be fixed. Using 
`git clang-format HEAD~1` only formats what you've changed, so you don't need 
to worry about spurious edits.

https://github.com/llvm/llvm-project/pull/69371
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to