dblaikie added a comment. In D157615#4647235 <https://reviews.llvm.org/D157615#4647235>, @StephenTozer wrote:
> In D157615#4646848 <https://reviews.llvm.org/D157615#4646848>, @dblaikie > wrote: > >> Might be worth rewording the commit, or splitting it - I'd say the >> introduction of `optdebug` should be the noteworthier part of this patch (or >> whichever patch introduces it) - so either "this patch adds optdebug, and a >> first/exemplar use of it in postra scheduler" or split it into a patch that >> just adds the attribute and no uses, and one that adds the use. > > SGTM, the scope of this patch has increased as-of the latest update. That > being said AFAIK Github PRs don't currently have support for stacked PRs, so > I imagine I'll need to have one review up at a time. Yeah, don't think we have a clear path for stacked PRs right now - so, yeah, will try to work through them one at a time. I guess you could post PRs that contain all the commits (eg: one review containing commit A, another review containing A and B, etc) - it doesn't have a good solution if large changes to predecessor patches need updates to latter patches (eg: if A causes invasive changes to B) - but otherwise it's probably OK-ish... (& in this case I don't think any changes to "adding optdebug" are likely to substantially change the nature of subsequent patches). But maybe not a big deal either way/can just wait for the subsequent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157615/new/ https://reviews.llvm.org/D157615 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
