StephenTozer added a comment. In D157615#4646848 <https://reviews.llvm.org/D157615#4646848>, @dblaikie wrote:
> Might be worth rewording the commit, or splitting it - I'd say the > introduction of `optdebug` should be the noteworthier part of this patch (or > whichever patch introduces it) - so either "this patch adds optdebug, and a > first/exemplar use of it in postra scheduler" or split it into a patch that > just adds the attribute and no uses, and one that adds the use. SGTM, the scope of this patch has increased as-of the latest update. That being said AFAIK Github PRs don't currently have support for stacked PRs, so I imagine I'll need to have one review up at a time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157615/new/ https://reviews.llvm.org/D157615 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
