RKSimon accepted this revision.
RKSimon added a comment.
LGTM with a couple of minors
================
Comment at: clang/lib/CodeGen/Targets/X86.cpp:1493
const llvm::StringMap<bool> &CalleeMap,
QualType Ty, StringRef Feature,
bool IsArgument) {
----------------
Remove Feature argument and hardcode to "avx" now that it only has 1 (avx)
caller?
================
Comment at: llvm/lib/Target/X86/X86Subtarget.cpp:275
+ size_t posEVEX512 = FS.rfind("+evex512");
+ size_t posAVX512F = FS.rfind("+avx512");
+
----------------
pengfei wrote:
> skan wrote:
> > Missing f?
> No, it's intentional. Sometimes, feature attributes may not have a full set
> of AVX512 features. If user only use e.g., "avx512bw", we should make sure
> "evex512" attached too.
Please add a comment as it looks like a typo.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159250/new/
https://reviews.llvm.org/D159250
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
