pengfei added inline comments.
================
Comment at: clang/lib/CodeGen/Targets/X86.cpp:1517
+ bool Caller256 = CallerMap.lookup("avx512f") && !CallerMap.lookup("evex512");
+ bool Callee256 = CallerMap.lookup("avx512f") && !CallerMap.lookup("evex512");
+
----------------
RKSimon wrote:
> typo in Callee256?
Good catch!
================
Comment at: clang/test/CodeGen/X86/avx512-error.c:9
+ return __builtin_ia32_sqrtpd512(a, _MM_FROUND_CUR_DIRECTION); //
expected-error {{'__builtin_ia32_sqrtpd512' needs target feature evex512}}
+}
----------------
RKSimon wrote:
> add __mmask64 test ? _knot_mask64 or _cvtmask64_u64 maybe?
Good point! This exposed a design problem. We cannot only check for 512-bit
vector, instead, we need to add `evex512` to all ZMM or 64-bit mask
builtin/intrinsic attribute list.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159250/new/
https://reviews.llvm.org/D159250
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
