mpaszkowski added a comment.

In D155978#4639499 <https://reviews.llvm.org/D155978#4639499>, @Keenuts wrote:

> In D155978#4639094 <https://reviews.llvm.org/D155978#4639094>, @mpaszkowski 
> wrote:
>
>> @Keenuts Hi Nathan, thanks for the patch! I agree with your approach and I 
>> think that this solution despite being a "hack" seems to be the most 
>> straightforward. Eventual differences could be handled in the backend. I 
>> would be open for other solutions in the future (for example in case other 
>> targets would also stumble upon a similar dilemma), but this looks like a 
>> completely valid approach to me.
>
> Thanks!
> Do you know how we can get this merged? (we have no commit access on our end).

Either I could push the patch for you (adding you as an author) or preferably 
you could gain commit access yourself for this and future patches. Please see 
this guide <https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access> 
and send an email to Chris (include your GitHub user name and a link to this 
Phabricator review). Please let me know which option you would prefer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155978/new/

https://reviews.llvm.org/D155978

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to