erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
Clean up the test layout a little as a part of the commit, otherwise, LGTM!
================
Comment at: clang/test/SemaCXX/concept-crash-on-diagnostic.cpp:28
+
+// expected-error@#1 {{no member named 'value' in 'is_convertible<bool,
bool>'}}
+
----------------
So I typically don't do the 'error' with a bookmark, just put the 'error' next
to the line that causes the error, and bookmark the note. It makes it easier
to read.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158061/new/
https://reviews.llvm.org/D158061
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
