zyounan added a comment.
Thanks for the review!
================
Comment at: clang/test/SemaCXX/concept-crash-on-diagnostic.cpp:26
+// Consume remaining notes/errors.
+// expected-note@* 0+{{}}
+// expected-error@* 0+{{}}
----------------
erichkeane wrote:
> Please don't do this, actually write out the remaining diagnostics. Same
> with the notes above.
>
> Additionally, please use the 'bookmark' feature of verify-consumer to make
> sure the diagnostics/notes are in proper order (which makes it easier to
> figure out when reviewing).
Thanks for reminding me. Will do that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158061/new/
https://reviews.llvm.org/D158061
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
