v.g.vassilev added inline comments.
================ Comment at: clang/unittests/Interpreter/CodeCompletionTest.cpp:38 + + std::vector<clang::CodeCompletionResult> Results; + ---------------- We should make this an out parameter instead of returning it by copy. ================ Comment at: clang/unittests/Interpreter/CodeCompletionTest.cpp:42 + const_cast<clang::CompilerInstance *>((*Interp)->getCompilerInstance()), + Prefix, 1, Prefix.size(), MainInterp.getCompilerInstance(), Results); + ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
