MaskRay resigned from this revision. MaskRay added a comment. This revision now requires review to proceed.
Sorry, after reading through D157750 <https://reviews.llvm.org/D157750>, I think the patch should be reverted. ================ Comment at: clang/test/CodeGen/fsplit-machine-functions.c:2 +// REQUIRES: system-linux +// REQUIRES: x86-registered-target +// REQUIRES: arm-registered-target ---------------- shenhan wrote: > MaskRay wrote: > > We usually place x86 tests under CodeGen/X86 and arm tests under CodeGen/ARM > I can moved the X86 cases to clang/test/CodeGen/X86, but there is no > clang/test/CodeGen/Arm or similar, shall I create "clang/test/CodeGen/Arm" > instead? Sorry, this is not llvm/test/CodeGen. For clang/test/CodeGen this is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
