MaskRay added inline comments.
================ Comment at: clang/test/CodeGen/fsplit-machine-functions.c:1 +// REQUIRES: system-linux +// REQUIRES: x86-registered-target ---------------- Any reason `system-linux` is needed? ================ Comment at: clang/test/CodeGen/fsplit-machine-functions.c:2 +// REQUIRES: system-linux +// REQUIRES: x86-registered-target +// REQUIRES: arm-registered-target ---------------- We usually place x86 tests under CodeGen/X86 and arm tests under CodeGen/ARM ================ Comment at: clang/test/Driver/fsplit-machine-functions.c:1 -// REQUIRES: arm-registered-target +// REQUIRES: x86-registered-target ---------------- If you only use `-###`, `// REQUIRES: x86-registered-target` is unneeded. ================ Comment at: clang/test/Driver/fsplit-machine-functions.c:3 -// RUN: %clang -### -target x86_64 -fprofile-use=default.profdata -fsplit-machine-functions %s -c -o %t.o 2>&1 | FileCheck -check-prefix=CHECK-OPT %s -// RUN: %clang -### -target x86_64 -fsplit-machine-functions %s -c -o %t.o 2>&1 | FileCheck -check-prefix=CHECK-OPT %s -// RUN: %clang -### -target x86_64 -fprofile-use=default.profdata -fsplit-machine-functions -fno-split-machine-functions %s -c -o %t.o 2>&1 | FileCheck -check-prefix=CHECK-NOOPT %s -// RUN: %clang -c -target arm-unknown-linux-gnueabi -fsplit-machine-functions %s -o %t.o 2>&1 | FileCheck -check-prefix=CHECK-TRIPLE %s +// RUN: %clang -### -target x86_64 -fsplit-machine-functions %s -c 2>&1 | FileCheck -check-prefix=CHECK_OPT %s +// RUN: %clang -### -target x86_64 -fprofile-use=default.profdata -fsplit-machine-functions -fno-split-machine-functions %s -c 2>&1 | FileCheck -check-prefix=CHECK_NOOPT %s ---------------- Use `--target=` for new tests. ================ Comment at: llvm/test/CodeGen/Generic/machine-function-splitter.ll:19 ; MFS_ON: Machine Function Splitter Transformation -; MFS_ON_NO: warning: -fsplit-machine-functions is not valid for +; MFS_ON-NOT: warning: -fsplit-machine-functions is not valid for +; MFS_ON-NOT: warning: ---------------- Delete `; MFS_ON-NOT: warning: -fsplit-machine-functions is not valid for`. It's unneeded given `; MFS_ON-NOT: warning:` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
