kiranchandramohan added inline comments.
================ Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:1388-1393 + // Convert module itself before any functions and operations inside, so that + // the OpenMPIRBuilder is configured with the OpenMP dialect attributes + // attached to the module by `amendOperation()` calls before then. llvm::IRBuilder<> llvmBuilder(llvmContext); + if (failed(translator.convertOperation(*module, llvmBuilder))) + return nullptr; ---------------- This change has to go in another patch reviewed by the general MLIR/LLVM dialect community. Not sure about mentioning too much about OpenMPIRbuilder or the OpenMPDialect here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147219/new/ https://reviews.llvm.org/D147219 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
