skatrak requested review of this revision. skatrak marked 11 inline comments as done. skatrak added a comment.
I think the change of approach to initialize the `OpenMPIRBuilderConfig` through the `amendOperation()` flow (rather than directly inside of `ModuleTranslation::getOpenMPBuilder()`) after @kiranchandramohan 's acceptance of the patch requires another review before landing. This patch still depends on a few pending patches so, in case significant changes have to be made to these, I think it's best to leave this review for last. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147219/new/ https://reviews.llvm.org/D147219 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits