thakis added a comment.

In D144634#4573483 <https://reviews.llvm.org/D144634#4573483>, @koops wrote:

> Can someone please check for MacOS? Yesterday when this support was 
> committed, the CHECK statements in tests loop_bind_codegen.cpp and  
> loop_bind_enclosed.cpp had failed on Mac

I patched this in and verified that `check-clang` now passes on macOS. Thanks!

> and I received a comment as follows:
>
>>   When relanding, please remember to put a link to the review in the commit 
>> message.

To do this, run `git commit --amend` and put `Differential Revision: 
https://reviews.llvm.org/D144634` at the bottom of the commit message. `git 
log` has many, many examples of this :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144634/new/

https://reviews.llvm.org/D144634

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to