ABataev added inline comments.
================ Comment at: clang/include/clang/AST/StmtOpenMP.h:291 + /// the frontend. + OpenMPDirectiveKind PrevMappedDirective = llvm::omp::OMPD_unknown; + ---------------- koops wrote: > ABataev wrote: > > I don't see where this field is stored/loaded for PCH support. You need add > > a support for this in Serialization. > Since the ASTReader and ASTWriter are used by the developer of clang, it is > preferable to show the internal state of the compiler as is, e.g. if "#pragma > omp loop bind(parallel)" is changed to "#pragma omp for" then the ASTWriter > has to show it as "#pragma omp for". I can change it to "#pragma omp loop > bind(parallel)" using the MappedDirective that is stored however, that would > be misleading to the developer of clang. How it is related to PCH? Try to serialize/deserialize the template and then try to create a new instance. There will be an issue since there is no serialization support, when you try to create new instance in the Rebuild... function (mapLoopConstruct will use OMPD_unknown as Prev value instead of oringal previous value, since it is not serialized/deserialized) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
