tbaeder added a comment.

In D156604#4572018 <https://reviews.llvm.org/D156604#4572018>, @hazohelet wrote:

> We need some tests for dtors because they are handled differently from other 
> functions.
> I think the current ExprConstant part would not cover the explicitly-called 
> dtors because the `HandleDestructorImpl` only has access to `CallLoc` and not 
> source range.
> Also new interpreter seems to point to the wrong source location on 
> implicitly-called dtor.
> Link: https://godbolt.org/z/1a6GW47eG
> I think it's good to have a fix for it in this patch if it's not too 
> complicated.

Yeah I know, there's a FIXME comment in the tests somewhere and it's on my list.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156604/new/

https://reviews.llvm.org/D156604

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to