hazohelet added a comment. We need some tests for dtors because they are handled differently from other functions. I think the current ExprConstant part would not cover the explicitly-called dtors because the `HandleDestructorImpl` only has access to `CallLoc` and not source range. Also new interpreter seems to point to the wrong source location on implicitly-called dtor. Link: https://godbolt.org/z/1a6GW47eG I think it's good to have a fix for it in this patch if it's not too complicated.
My previous comment "All explicitly-written function calls should have its AST in CallExpr field." was wrong for destructors. Sorry for the confusion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156604/new/ https://reviews.llvm.org/D156604 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
