[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3542
+    LangAS AAS = getASTAllocaAddressSpace();
+    LangAS EAS = E->getType().getAddressSpace();
+    if (AAS != EAS) {
----------------
`E->getType().getAddressSpace()` is actually the top-level qualification of the 
type; you need `E->getType()->getPointeeType().getAddressSpace()`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156539/new/

https://reviews.llvm.org/D156539

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits