carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land.
LGTM! Feel free to add the comment about the implications of using the flag in the docs. ================ Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:270 +for C++20 and above, empowering specific checks +to detect macro definitions within modules. +)"), ---------------- PiotrZSL wrote: > carlosgalvezp wrote: > > Should we document the implications/risks of enabling this, so people are > > informed? Also the fact that is experimental and subject to change. > Something like "May cause performance & parsing issues, and therefore is > considered experimental." ? I'ts fine with me. Sounds good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156161/new/ https://reviews.llvm.org/D156161 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
