PiotrZSL added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:266
+static cl::opt<bool>
EnableModuleHeadersParsing("enable-module-headers-parsing",
+ desc(R"(
----------------
carlosgalvezp wrote:
> --experimental-enable-module-headers-parsing
I removed 'experimental' because it were messing with the --help output, were
causing it be very wide.
And it's no longer hidden option now. so should it be hidden & experimental ?
Or non hidden...
================
Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:270
+for C++20 and above, empowering specific checks
+to detect macro definitions within modules.
+)"),
----------------
carlosgalvezp wrote:
> Should we document the implications/risks of enabling this, so people are
> informed? Also the fact that is experimental and subject to change.
Something like "May cause performance & parsing issues, and therefore is
considered experimental." ? I'ts fine with me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156161/new/
https://reviews.llvm.org/D156161
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
