ismailp added inline comments. ================ Comment at: test/CodeGenCXX/cxx1z-constexpr-if.cpp:2 @@ -1,2 +1,3 @@ // RUN: %clang_cc1 -std=c++1z %s -emit-llvm -o - | FileCheck %s --implicit-check-not=should_not_be_used +// RUN: %clang_cc1 -std=c++1z %s -DCHECK_CONVERSION -verify %s ---------------- rsmith wrote: > ismailp wrote: > > Is there a more elegant way to do this? The previous check didn't seem to > > work with diagnostics. > Tests for semantic issues should go into test/SemaCXX (organized by category) > or test/CXX (organized by section of the standard). In this case, > test/CXX/stmt.stmt/stmt.select/stmt.if/p2.cpp is probably the most > appropriate place (somewhere in its `namespace ccce`, perhaps). Thanks! I've done that, and pushed.
Repository: rL LLVM https://reviews.llvm.org/D24158 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
