HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed.
D155529#inline-1505573 <https://reviews.llvm.org/D155529#inline-1505573> But what does `clang-format` without this patch format? I just want to make sure, that we don't have a regression when this lands, but D155529 <https://reviews.llvm.org/D155529> not. ================ Comment at: clang/unittests/Format/ConfigParseTest.cpp:411-425 CHECK_PARSE("BasedOnStyle: Google\n" "ConstructorInitializerAllOnOneLineOrOnePerLine: true\n" "AllowAllConstructorInitializersOnNextLine: false", PackConstructorInitializers, FormatStyle::PCIS_CurrentLine); Style.PackConstructorInitializers = FormatStyle::PCIS_NextLine; CHECK_PARSE("BasedOnStyle: Google\n" "ConstructorInitializerAllOnOneLineOrOnePerLine: false", ---------------- You need to write similar tests to show that your backwards compatible parsing works as intended. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155239/new/ https://reviews.llvm.org/D155239 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
