gedare added a comment.
After doing this, I'm not too sure about the value of keeping the higher-level
`CStyleCasts`, `ConditionalStatements`, and `EmptyParentheses` as options to
`SpacesInParens`. However, the behavior of `Always` is actually "Always except
for `CStyleCasts` and `EmptyParentheses`, which is consistent with how
`SpacesInParentheses` currently works. I think that is a bit buggy/brittle, but
I kept the behavior as-is, and modeled the design of this after
`SpaceBeforeParens`.
I might prefer to make `Always` really mean every single parens, and simply have
`Never`, `Always`, and `Custom`. Inside Custom, there can be a `Other` option
to catch anything that isn't explicitly controlled.
I could make this work, mapping the previous behavior of `SpacesInParenthesis`
to Custom with `Options = {ConditionalStatements: true, Other: true}`. I'll sit
on this a bit, but if I don't hear objections (to the entire point of this rev,
or to my next step), I will redo the options like this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155239/new/
https://reviews.llvm.org/D155239
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
