steakhal added inline comments.

================
Comment at: clang/docs/ReleaseNotes.rst:907
+  Any use of this flag will result in an error.
+  (`7cd1f3ad22e4 <https://github.com/llvm/llvm-project/commit/7cd1f3ad22e4>`_)
+- Fixed a null-pointer dereference crash inside the ``MoveChecker``.
----------------
xazax.hun wrote:
> I think we should mention  something like "Use -fstrict-flex-array=<N> 
> instead if necessary."
Good point.


================
Comment at: clang/docs/ReleaseNotes.rst:908
+  (`7cd1f3ad22e4 <https://github.com/llvm/llvm-project/commit/7cd1f3ad22e4>`_)
+- Fixed a null-pointer dereference crash inside the ``MoveChecker``.
+  (`d172b65ef001 <https://github.com/llvm/llvm-project/commit/d172b65ef001>`_)
----------------
xazax.hun wrote:
> I think we usually do not mention crash fixes in the changelog. We have them 
> in almost every release and sometimes there are quite a few of them.
I won't mention the explicit commit where it was fixed.
However, downstream users might wanna know about crashes and fixes that 
happened in this release.
And speaking about past practices about release notes, I think we can improve 
on that TBH.
We can move it down on the list if you want, but I'd rather keep it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155445/new/

https://reviews.llvm.org/D155445

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to