v.g.vassilev added a comment.

In D41416#4492367 <https://reviews.llvm.org/D41416#4492367>, @v.g.vassilev 
wrote:

> Address most of the comments. I will need some help with the 
> `Modules/pr60085.cppm` failure. I suspect we pass to CodeGen some 
> instantiation by iterator index and that does not work as the instantiations 
> are lazily triggered upon use now.

In fact it looks like it fails exactly in the same way as described in the 
original report https://github.com/llvm/llvm-project/issues/60085. The commit 
message in https://github.com/llvm/llvm-project/commit/78e48977a6e67 hints at 
the fact that the issue was gone surprisingly. I suspect that test case stopped 
reproducing the underlying issue by chance. That probably means that this patch 
is not breaking anything but exposing an underlying problem...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D41416/new/

https://reviews.llvm.org/D41416

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to