ChuanqiXu added a comment. > I will need some help with the Modules/pr60085.cppm failure.
I am looking at https://reviews.llvm.org/D154914 so maybe I can't look this deeply now. If there are concrete and small issues, maybe I can try to take a look. Hope this helps. ================ Comment at: clang/lib/AST/DeclTemplate.cpp:366 + Args, + TemplateParameterList *TPL) const { + CommonBase *CommonBasePtr = getMostRecentDecl()->getCommonPtr(); ---------------- v.g.vassilev wrote: > Hahnfeld wrote: > > ChuanqiXu wrote: > > > TPL here looks not used. > > This is required because of the argument forwarding from > > `findSpecializationImpl` below... > Are you suggesting to make this replacement: `TPL` -> `/*TPL*/`? I am not sure. I'm just wondering if there will be a static checker emits warnings for unused arguments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41416/new/ https://reviews.llvm.org/D41416 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
