capfredf marked 5 inline comments as done. capfredf added inline comments.
================ Comment at: clang/include/clang/Interpreter/Interpreter.h:117 ASTContext &getASTContext(); + void CodeComplete(llvm::StringRef Input, size_t Col, size_t Line = 1); const CompilerInstance *getCompilerInstance() const; ---------------- v.g.vassilev wrote: > I could not find where this interface was used. If it is unused, let'd drop > it. it is used at L86 of CodeCompletion.cpp ================ Comment at: clang/lib/Interpreter/IncrementalParser.cpp:376 // Create FileID for the current buffer. - FileID FID = SM.createFileID(std::move(MB), SrcMgr::C_User, /*LoadedID=*/0, - /*LoadedOffset=*/0, NewLoc); + // FileID FID = SM.createFileID(std::move(MB), SrcMgr::C_User, /*LoadedID=*/0, + // /*LoadedOffset=*/0, NewLoc); ---------------- v.g.vassilev wrote: > Why we had to comment out this line? This is old code. `FID` is created in a different way. See below. I will remove the commented code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
