yaxunl marked 3 inline comments as done. yaxunl added inline comments.
================ Comment at: clang/docs/AMDGPUSupport.rst:20 + +Clang supports OpenCL, HIP and OpenMP on amdgpu target. + ---------------- lamb-j wrote: > arsenm wrote: > > "on amdgpu target" doesn't sound grammatical > "for the //amdgpu// target"? or > "on AMD GPU targets?" > will use "on AMD GPU targets". ================ Comment at: clang/docs/AMDGPUSupport.rst:49 + * - ``__AMDGCN_CUMODE__`` + - Defines as 1 if the CU mode is enabled and 0 if the WGP mode is enabled. + * - ``__AMDGCN_UNSAFE_FP_ATOMICS__`` ---------------- lamb-j wrote: > Defined? will fix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/ https://reviews.llvm.org/D154133 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
