jdoerfert added inline comments.

================
Comment at: clang/docs/AMDGPUSupport.rst:33
+   * - ``__AMD__``
+     - Indicates that the code is being compiled for an AMD GPU.
+   * - ``__AMDGPU__``
----------------
FWIW, this arguably confusing use of __AMD__, and duplication of __AMDGPU__, 
should be deprecated and removed. Or at least not advocated...


================
Comment at: clang/docs/AMDGPUSupport.rst:62
+     - Defined if fast FMA instruction is available.
+   * - ``__AMDGCN_WAVEFRONT_SIZE``
+     - Defines the wavefront size. Allowed values are 32 and 64.
----------------
Any reason this one does not end in `__`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154133/new/

https://reviews.llvm.org/D154133

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to