shafik added inline comments.
================
Comment at: clang/lib/Sema/SemaDecl.cpp:18217
+ NewFD->setIsPlaceholderVar(LangOpts.CPlusPlus && II && II->isPlaceholder());
if (PrevDecl && !isa<TagDecl>(PrevDecl)) {
----------------
cor3ntin wrote:
> shafik wrote:
> > Why can't we fold this into `FieldDecl::Create`? This comment applies in
> > some other places as well.
> By adding a parameter to FieldDecl::Create? We could, I'm not sure it would
> necessarily be cleaner. Let me know what you prefer.
It seems like having the code consolidated make for better maintainability and
figuring this out for future folks but I am willing to be convinced otherwise.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153536/new/
https://reviews.llvm.org/D153536
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
