aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LG aside from the few suggested changes and moving the header to the Inputs
directory.
================
Comment at: clang/lib/Sema/Sema.cpp:1350
continue; // Deleted functions are supposed to be unused.
+ SourceRange DiagRange = SourceRange(DiagD->getLocation());
+ if (const ASTTemplateArgumentListInfo *ASTTAL =
----------------
hazohelet wrote:
> aaron.ballman wrote:
> > Does `DiagD->getSourceRange()` not give you the same results?
> `FunctionDecl::getSourceRange` also covers the return type and the function
> body if it exists, so we cannot use it here.
Ah, okay, that makes sense. Thank you!
<not your problem>
I think we should consider adding `SourceRange` accessors for various
interesting ranges like this so that we don't need to use ad hoc solutions in
various places.
</not your problem>
================
Comment at: clang/test/Misc/diag-unused-source-ranges.h:1
+static void thing(void) {}
----------------
tbaeder wrote:
> Moving this file to `Inputs/` would make sense I think.
+1
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152707/new/
https://reviews.llvm.org/D152707
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
