[PATCH] D152707: [clang][Sema] Provide source range to several Wunused warnings

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang/lib/Sema/Sema.cpp:1350
           continue; // Deleted functions are supposed to be unused.
+        SourceRange DiagRange = SourceRange(DiagD->getLocation());
+        if (const ASTTemplateArgumentListInfo *ASTTAL =
----------------
Does `DiagD->getSourceRange()` not give you the same results?


================
Comment at: clang/lib/Sema/Sema.cpp:1384
           DiagD = cast<VarDecl>(*I);
+        SourceRange DiagRange = SourceRange(DiagD->getLocation());
+        if (const auto *VTSD = dyn_cast<VarTemplateSpecializationDecl>(DiagD))
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152707/new/

https://reviews.llvm.org/D152707

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits