aaron.ballman added subscribers: majnemer, rnk. aaron.ballman added a comment.
I seem to recall this came up in the past and there were issues, so I did some digging around our mail archives and figured I'd share what I found: https://discourse.llvm.org/t/big-clang-dll-plug-in-mechanism-revision/19376/5 https://discourse.llvm.org/t/distributing-libclang-cpp-dll-for-windows-in-the-pre-built-downloads/54778 https://lists.llvm.org/pipermail/llvm-dev/2017-June/113925.html However, those concerns seem to be more around dllexport behavior on Windows, so LLVM_LIBRARY_VISIBILITY shouldn't matter there. CC @rnk @majnemer @compnerd for confirmation that we shouldn't also be thinking about Windows symbol exports. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152051/new/ https://reviews.llvm.org/D152051 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
