Sedeniono reopened this revision.
Sedeniono added a comment.
This revision is now accepted and ready to land.

Ok, here is the 2nd attempt at fixing the issue. The patch is based on the 
current main branch.

Regarding `LineJoiner::join()`: Turns out, not setting `A.Level` but reverting 
the original crash fix of https://reviews.llvm.org/D129064 no longer produces 
the crash. From debugging it I guess this is because of 
https://reviews.llvm.org/D144296 (although I haven't bisected it to confirm 
this). I am not really sure whether setting `A.Level` should or should not be 
done. So I am keeping it as it is.

But therefore note, since https://reviews.llvm.org/D144296 seems to not have 
been merged into the LLVM 16, the present fix can probably not be merged 
without further changes.

So, the new patch basically just reverts the original fix of 
https://reviews.llvm.org/D129064 (i.e. it re-introduces the `resize()` in 
`LevelIndentTracker::nextLine()`). The other changes are just cosmetics and 
additional tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151047/new/

https://reviews.llvm.org/D151047

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to