rsmith added inline comments. ================ Comment at: include/clang/Basic/Attr.td:201 @@ -200,2 +200,3 @@ class Declspec<string name> : Spelling<name, "Declspec">; +class MS<string name> : Spelling<name, "MS">; class CXX11<string namespace, string name, int version = 1> ---------------- Is there some better description for this than MS? `__declspec` is also an MS attribute. Is it fair to call this IDL or MSIDL or similar?
================ Comment at: include/clang/Parse/Parser.h:2109-2110 @@ -2108,4 +2108,4 @@ - void handleDeclspecAlignBeforeClassKey(ParsedAttributesWithRange &Attrs, - DeclSpec &DS, Sema::TagUseKind TUK); + void stripSomeAttribsOffDeclSpec(ParsedAttributesWithRange &Attrs, + DeclSpec &DS, Sema::TagUseKind TUK); ---------------- Can you give this a less vague-sounding name? :) ================ Comment at: lib/Parse/ParseDeclCXX.cpp:3950 @@ +3949,3 @@ + ConsumeToken(); + if (Name->getName() == "uuid") + ParseMicrosoftDeclSpecArgs(Name, Loc, attrs, AttributeList::AS_MS); ---------------- Is anything known to fail if you accept arbitrary attributes here, or is this just the only one you /know/ you need right now? (If we can ditch the whitelist, that would seem preferable.) https://reviews.llvm.org/D23895 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
