v.g.vassilev added a comment. Generally lgtm, let's extend the test coverage.
================ Comment at: clang/lib/Interpreter/DeviceOffload.cpp:1 +//===-------------- Offload.cpp - CUDA Offloading ---------------*- C++ -*-===// +// ---------------- Likewise. ================ Comment at: clang/lib/Interpreter/DeviceOffload.h:1 +//===--------------- Offload.h - CUDA Offloading ----------------*- C++ -*-===// +// ---------------- We should probably update the name here as well and maybe drop CUDA? ================ Comment at: clang/test/Interpreter/CUDA/sanity.cu:10 +// CHECK: CUDA Error: 0 + +%quit ---------------- Let's extend the coverage with some more standard hello world examples. We can draw some inspiration from https://github.com/root-project/cling/tree/master/test/CUDADeviceCode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146389/new/ https://reviews.llvm.org/D146389 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
